orppst / pst-gui

web based front end for the tool
Mozilla Public License 2.0
0 stars 0 forks source link

Decompose Technical Goals #187

Open mwapst opened 3 months ago

mwapst commented 3 months ago

Rebrand Technical Goals as Performance Parameters, move spectral windows stuff to its own form, available from the navigation panel.

Observation form : allow the selection of a single spectral window set.

Something like this is necessary anyway because the current Observation form does not display the spectral windows stuff.

I think it might be useful if each selectable item were given a name by the user to aid identification once there are many. Clearly target is ok but maybe performance params and spectral window sets could each do with a name. And maybe the user could enter the name directly into the Observation (including target) as well as being able to scroll through a list.

mwapst commented 3 months ago

The data model does not seem to provide direct access to the ScienceSpectralWindow, it's always tied to a TechnicalGoal, so the PerformanceParameters and spectral stuff cannot be separated out into separate data entry forms at the moment.

Observation form : change to display any ScienceSpectralWindow data created in the Technical Goal form.

pahjbo commented 3 months ago

if this were to be refactored, then it is definitely the https://github.com/ivoa/ProposalDM that would have to be changed first - I agree that it would be nice to have the spectral windows as more "separate" as some common template ones could be set up that would be applicable in many cases - e.g. OH line etc.