search

orrsella / sbt-sublime

An sbt plugin for generating Sublime Text projects with library dependencies sources
Other
137 stars 9 forks source link

Please release a version compatible with SBT 1.0 #19

Closed agemooij closed 7 years ago

agemooij commented 7 years ago

This plugin is one of the last ones on my list of essential plugins before I can move all our projects to SBT 1.0. It would be great if you could release a version built against Scala 2.12 and SBT 1.0.

orrsella commented 7 years ago

Hey, I want to do this, but just haven't gotten around to it. Will try to in next weekend.

orrsella commented 7 years ago

I'm fallen a bit out of touch with the Scala ecosystem. Have you done this recently for other plugins? Any hoops I'll need to jump thru in order to get this working from sbt 0.13?

agemooij commented 7 years ago

I have done this for two of my own plugins so far and it varied from minor tweaks to add support for cross-building to dealing with some code changes for deprecated or removed API.

I had a quick look at the build file for sbt-sublime and it seems to still support SBT 0.12 and Scala 2.9. would you be OK with removing that to simplify things a little bit?

agemooij commented 7 years ago

Based on a quick look at the build file and source code I don't see any potential problems so I can try to hack something together as a starting point this week.

orrsella commented 7 years ago

I released version 1.1.2 which should work for sbt 1.0. Please give it a try and let me know if you have any issues. Thanks!

agemooij commented 7 years ago

@orrsella Awesome, thanks!

I tested it successfully. I also updated the plugin status on the SBT 1.0 migration wiki so other users are aware of the release.

I noticed that the README still says that you should use 1.1.1 for SBT 0.13.x but since you have cross-released the latest version, that should not be necessary. Both user groups should be able to use 1.1.2 now.

Thanks again!

agemooij commented 7 years ago

@orrsella I just ran into the problem of 1.1.2 not having been cross-released but released only for SBT 1.0.

This makes it hard for me to run sbt-sublime on multiple projects, some of which have already transitioned to 1.0 but some of which are not under my control and still run 0.13. It forces me to keep separate plugin configurations for both SBT versions (I have 0.13 symlinked to 1.0 at the moment).

Any chance you could release 1.1.2 for 0.13 too? It should be completely seamless to do so.

orrsella commented 7 years ago

Sure, I actually ran into some problems trying to cross release so only released for 1.0.

I used: sbt> release cross with-defaults but it only released for the version of sbt I was running.

Any idea what I'm doing wrong?

agemooij commented 7 years ago

It should just be ^ publish for a full cross release or, if you want to release a specific version, switch to correct SBT version using ^^ 0.13.16 and then do a normal publish.

I'm not sure how the release plugin interacts with this though.

agemooij commented 7 years ago

These were the (minimal) docs I used: http://www.scala-sbt.org/0.13/docs/sbt-0.13-Tech-Previews.html#sbt-cross-building

orrsella commented 7 years ago

That's what I did — switched to 0.13.16. Version 1.1.2 for 0.13 should be in maven central soon (it's already in sonatype).

agemooij commented 7 years ago

Awesome, thanks!