search

orsjb / HappyBrackets

HappyBrackets is an audio-focused library and toolkit for creative coding for the internet of things.
Apache License 2.0
36 stars 3 forks source link

Broadcast listeners are also receiving /device/alive messages #21

Closed orsjb closed 8 years ago

orsjb commented 8 years ago

Broadcast listeners are also receiving /device/alive messages. Does this mean they're listening all on the same channel? Is /device/alive now being broadcast? That would make sense and if so this is not necessarily an issue. Only if that's a mistake. Still it might be sensible to have a different channel for these messages.

samgwise commented 8 years ago

Yes I believe that is the correct behavior for the current design.

On 02/12/2016 5:44 PM, "orsjb" notifications@github.com wrote:

Broadcast listeners are also receiving /device/alive messages. Does this mean they're listening all on the same channel? Is /device/alive now being broadcast? That would make sense and if so this is not necessarily an issue. Only if that's a mistake. Still it might be sensible to have a different channel for these messages.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/orsjb/HappyBrackets/issues/21, or mute the thread https://github.com/notifications/unsubscribe-auth/AOWCNNRjeH4QMD0-ZGk2m93n456TLMNoks5rD75TgaJpZM4LCP9n .

orsjb commented 8 years ago

I've added an 'else' clause to so that only messages not already consumed by the DeviceConnection manager get forwarded to listeners.

orsjb commented 8 years ago

Sorry that should read the net.happybrackets.device.network.NetworkCommunication class.