search

orsjb / HappyBrackets

HappyBrackets is an audio-focused library and toolkit for creative coding for the internet of things.
Apache License 2.0
36 stars 3 forks source link

DeviceStratumSetTest fails #85

Closed jacobsimionato closed 1 year ago

jacobsimionato commented 1 year ago

When I run gradle deploy, I get a single test failure in Class net.happybrackets.core.scheduling.DeviceStratumSetTest:

java.lang.AssertionError
    at net.happybrackets.core.scheduling.DeviceStratumSetTest.testStratumAdjust(DeviceStratumSetTest.java:27)
    at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
    at java.base/java.lang.reflect.Method.invoke(Method.java:578)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
    at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
    at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)

I can work around this by commenting out that assertion for now, but let's investigate this and figure out if it's a real failure and related to upgrading some of the dependency versions, or broken for some other reason.

angelofraietta commented 1 year ago

Just one thing on this. Does it fail every time or just sometimes?

On Tue, 4 Jul 2023 at 3:04 pm, jacobsimionato @.***> wrote:

When I run gradle deploy, I get a single test failure in Class net.happybrackets.core.scheduling.DeviceStratumSetTest:

java.lang.AssertionError at net.happybrackets.core.scheduling.DeviceStratumSetTest.testStratumAdjust(DeviceStratumSetTest.java:27) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) at java.base/java.lang.reflect.Method.invoke(Method.java:578) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)

I can work around this by commenting out that assertion for now, but let's investigate this and figure out if it's a real failure and related to upgrading some of the dependency versions, or broken for some other reason.

— Reply to this email directly, view it on GitHub https://github.com/orsjb/HappyBrackets/issues/85, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJJYNJ6J6FEWQ2T2MKO6IDXOOP4VANCNFSM6AAAAAAZ5GGUFE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- -- Dr Angelo Fraietta A.Eng, A.Mus.A, BA(Hons), PhD.

Home Page https://www.newcastleguitarlessons.com.au/ https://orcid.org/0000-0002-3171-8491

There are those who seek knowledge for the sake of knowledge - that is CURIOSITY There are those who seek knowledge to be known by others - that is VANITY There are those who seek knowledge in order to serve - that is LOVE Bernard of Clairvaux (1090 - 1153)

jacobsimionato commented 1 year ago

I eventually realised if I run it a few times, it passes - just as your guide says :-D. Apologies for the noise!

angelofraietta commented 1 year ago

The issue is the way the jvm works. I will give you a detailed example of what is happening.

On Wed, 26 Jul 2023 at 9:31 pm, jacobsimionato @.***> wrote:

I eventually realised if I run it a few times, it passes - just as your guide says :-D. Apologies for the noise!

— Reply to this email directly, view it on GitHub https://github.com/orsjb/HappyBrackets/issues/85#issuecomment-1651611720, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJJYNNQSOZ27L3TLNIAMA3XSD5ZBANCNFSM6AAAAAAZ5GGUFE . You are receiving this because you commented.Message ID: @.***>

-- -- Dr Angelo Fraietta A.Eng, A.Mus.A, BA(Hons), PhD.

Home Page https://www.newcastleguitarlessons.com.au/ https://orcid.org/0000-0002-3171-8491

There are those who seek knowledge for the sake of knowledge - that is CURIOSITY There are those who seek knowledge to be known by others - that is VANITY There are those who seek knowledge in order to serve - that is LOVE Bernard of Clairvaux (1090 - 1153)

angelofraietta commented 1 year ago

This is what I believe the issue is.

What happens in the JVM is that they use what is called the Just In Time (JIT) compiler. What this does is parse the compiled java byte code and turn that into machine code to execute. When it has done this, it caches the machine code and it does not need to compile it again. So what i did for code that i needed ti run in time was execute it a few times to cache the machine code. I mentioned it one of my papers. You were really able to experience when you first downloaded a patch to happy brackets that started playing sound. It jitters at first. If you pause and then restart the jitter goes.

I saw a very similar thing withe the synchniser code would fail tests. I was also able to verify the issue. So did the same task multiple times to get timer code compiled and then did timing tests.

On Thu, 27 Jul 2023 at 5:16 am, Angelo Fraietta < @.***> wrote:

The issue is the way the jvm works. I will give you a detailed example of what is happening.

On Wed, 26 Jul 2023 at 9:31 pm, jacobsimionato @.***> wrote:

I eventually realised if I run it a few times, it passes - just as your guide says :-D. Apologies for the noise!

— Reply to this email directly, view it on GitHub https://github.com/orsjb/HappyBrackets/issues/85#issuecomment-1651611720, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJJYNNQSOZ27L3TLNIAMA3XSD5ZBANCNFSM6AAAAAAZ5GGUFE . You are receiving this because you commented.Message ID: @.***>

--

Dr Angelo Fraietta A.Eng, A.Mus.A, BA(Hons), PhD.

Home Page https://www.newcastleguitarlessons.com.au/ https://orcid.org/0000-0002-3171-8491

There are those who seek knowledge for the sake of knowledge - that is CURIOSITY There are those who seek knowledge to be known by others - that is VANITY There are those who seek knowledge in order to serve - that is LOVE Bernard of Clairvaux (1090 - 1153)

-- -- Dr Angelo Fraietta A.Eng, A.Mus.A, BA(Hons), PhD.

Home Page https://www.newcastleguitarlessons.com.au/ https://orcid.org/0000-0002-3171-8491

There are those who seek knowledge for the sake of knowledge - that is CURIOSITY There are those who seek knowledge to be known by others - that is VANITY There are those who seek knowledge in order to serve - that is LOVE Bernard of Clairvaux (1090 - 1153)