search

orta / ARAnalytics

Simplify your iOS/Mac analytics
MIT License
1.84k stars 217 forks source link

+setupWithAnalytics contains some disreputable code additions #170

Closed cbowns closed 9 years ago

cbowns commented 9 years ago

I noticed this small probable issue in ARAnalytics.m when working on a forthcoming integration: 

    // Crashlytics / Crittercism should stay at the bottom of this,
    // as they both need to register exceptions, and you'd only use one.

    if (analyticsDictionary[ARCrashlyticsAPIKey]) {
        [self setupCrashlyticsWithAPIKey:analyticsDictionary[ARCrashlyticsAPIKey]];
    }
    if (analyticsDictionary[ARFabricKits]) {
        [self setupFabricWithKits:analyticsDictionary[ARFabricKits]];
    }
…

That chunk is followed by five other integrations which were presumably dropped in after Crashlytics/Fabric and Crittercism. Should they be moved up? (Probably.) (Want a PR for this?)

orta commented 9 years ago

Yeah, best move them back to the bottom, and yeah, a PR'd be nice.