orta / ARAnalytics

Simplify your iOS/Mac analytics
MIT License
1.84k stars 217 forks source link

Adobe provider via ADBMobile #178

Closed synthemesc closed 9 years ago

synthemesc commented 9 years ago

This is a bit of an awkward addition as the way ADBMobile does things is a bit awkward — specifically, there is contextual information you may add into your analytics, but the vast majority of your configuration happens via an ADBMobileConfig.json file that's bundled into your project.

I followed the convention of using "data" to refer to that additional data (e.g, "setupAdobeWithData:" when I think it's more idiomatic to say "setupAdobeWithDictionary:"), because that's what the ADBMobile documentation refers to and it might confuse others.

This has been used in another project for a few months now and seems to work well.

orta commented 9 years ago

This looks good, any chance you can add yourself to the changelog?

synthemesc commented 9 years ago

Will do. What's the format you want that to take?

orta commented 9 years ago

Should be the same as the rest of the CHANGELOG - will need a rebase too, just accepted a change that also edits the podspec #179 - this is a point release change

orta commented 9 years ago

I've manually merged this into master, thanks!