Completely untested. Fix Localytics screen tracking using events. Should use dedicated screen tracking method instead.

orta / ARAnalytics

Simplify your iOS/Mac analytics

MIT License

1.84k stars 217 forks source link

Completely untested. Fix Localytics screen tracking using events. Should use dedicated screen tracking method instead. #216

Closed ftvs closed 7 years ago

ftvs commented 8 years ago

didShowNewPageView is not actually ever called. didShowNewPageView:withProperties: is called, but LocalyticsProvider does not implement it, so a normal event is triggered in ARAnalyticalProvider instead.

Completely untested.

orta commented 8 years ago

Any chance you can do a quick find in project to see if other providers have the same problem?

ftvs commented 8 years ago

At a glance, potentially SnowPlow, UMeng. Providers that did not override or call the "designated method" might have the same issue: https://github.com/orta/ARAnalytics/search?utf8=%E2%9C%93&q=didShowNewPageView%3ApageTitle+%7B&type=Code

orta commented 7 years ago

OK, gonna call this PR as closed - happy to have it resubmitted 👍