search

orta / ARAnalytics

Simplify your iOS/Mac analytics
MIT License
1.84k stars 217 forks source link

Fabric / Answers confusion #221

Open delebedev opened 8 years ago

delebedev commented 8 years ago

Looks like "Answers" is more about analytics + Crashlytics has a bunch of methods deprecated:

- (void)logEvent:(NSString *)eventName CLS_DEPRECATED("Please refer to Answers +logCustomEventWithName:");

Should I modify existing Fabric provider in favour of these changes or I need new Answers provider?

orta commented 8 years ago

Sure for either, I don't know too much about the Fabric integration, whatever you feel is best :+1:

delebedev commented 8 years ago

@orta I see :smile: Even though Fabric is not the best name for this particular provider, nobody (me) wants to mess with renaming it to Crashlytics and migrating to new version etc.

However, Answers is completely unrelated to this and should be separate provider, will do PR

cemaleker commented 8 years ago

What is the update on this. I might improve Fabric / Crashlytics implementations if needed.

delebedev commented 8 years ago

In my project, I've made separate Crashlytics provider with purpose of adding logs to crash reports. Is that something you find useful @cemaleker?

cemaleker commented 8 years ago

@garnett Yes definately. But I also want to track events with Answers. I think I can do this with the current Answers provider, right?

delebedev commented 8 years ago

@cemaleker that's correct, even thought it is called FabricProvider it triggers Answers methods inside.