Closed arifken closed 8 years ago
@ashfurrow ^
Cool, will take a look!
Everything looks good to me :+1: Documentation and comments are :100: I'll add some tests to https://github.com/orta/ARAnalytics/blob/master/Example/ARAnalyticsiOSTests/ARAnalyticsDSLTests.m and merge.
oh whoops, I meant to add tests as well. I can do that if you want!
Sure, sounds great!
Tests added! I was having some issues with run loops/verification timing in OCMock 2.x so I migrated the test to 3.2.1. Hope that's ok. All tests passing
Tests + OCMock upgrade look :100: to me! @orta can you lend a pair of second eyes?
Alright, given it a second look over and seems :+1: to me
Revised version of https://github.com/orta/ARAnalytics/pull/246
In our analytics implementation, the page name for screen views (as well as the event names for actions) can only be derived at the time when the screen view is triggered. This PR allows the developer to optionally return the page name and event name from block parameters passed in the ARAnalytics setup dictionary.