orta / ARAnalytics

Simplify your iOS/Mac analytics
MIT License
1.84k stars 217 forks source link

Dispatch GA right away while debugging #262

Closed superarts closed 8 years ago

superarts commented 8 years ago

Google Analytics doesn't dispatch tracking events by default. While this makes perfect sense in production, it would be convenient to see real time events come through. So I added a little bit piece of code to dispatch GA events if it's a DEBUG build.

In the other hand, if you don't think it's a good idea to make it a default behaviour, I'd like to comment here that we can always call dispatchGA manually after a [ARAnalytics event:] call.

GoogleAnalyticsProvider *gaProvider =
    (GoogleAnalyticsProvider *)[ARAnalytics providerInstanceOfClass:[GoogleAnalyticsProvider class]];
[gaProvider dispatchGA];
orta commented 8 years ago

Yep, this looks good - can you add a CHANGELOG entry please, then this is 👍

superarts commented 8 years ago

Thanks, what should I do with the version number please? Just add a line above 3.9.2?

orta commented 8 years ago

Yeah, please, just make a section called "Master" 👍

orta commented 8 years ago

Awesomebeans - will merge on green - thanks!

superarts commented 8 years ago

Squashed and pushed. Thanks so much!

orta commented 8 years ago

Great job

superarts commented 8 years ago

🙇