search

orta / ARAnalytics

Simplify your iOS/Mac analytics
MIT License
1.84k stars 217 forks source link

setupWithAnalytics missing support for Firebase #291

Open ScottYelich opened 7 years ago

ScottYelich commented 7 years ago

setupWithAnalytics missing support for Firebase (ARAnalytics 4.0.0)

Perhaps: ARFIRAnalyticsKey

+ (void)setupWithAnalytics:(NSDictionary *)analyticsDictionary {
// ...
    if (analyticsDictionary[ARFIRAnalyticsKey]) {
        [self setupFirebaseAnalytics]; // :analyticsDictionary[ARFIRAnalyticsKey]];
    }
orta commented 7 years ago

Cool, wanna add that?

ScottYelich commented 7 years ago

I've added it locally... after I test it out and get Firebase working... I'd feel more comfortable making a PR.

orta commented 7 years ago

Awesome 👍