search

orta / ARAnalytics

Simplify your iOS/Mac analytics
MIT License
1.84k stars 217 forks source link

[DSL] Don’t dispatch blocks if view controller has been deallocated. #301

Closed alloy closed 7 years ago

alloy commented 7 years ago

While I haven’t been able to proof it, nor create a failing test, I’m pretty sure that this issue leads to some of the cases we’re having where blocks that try to grab properties from VCs that really should not be nil lead to exceptions because we’re trying to insert nil into a NSDictionary.

Also did some faffing to get test suite to run on iOS 9 and some cleanup (not sure why there was a copy of the podspec in Example/?).

alloy commented 7 years ago

I don’t know why this is failing. Works fine locally and I’ve changed the Xcode project to build with deployment target 9.0

orta commented 7 years ago

Will take a look

orta commented 7 years ago

Boo - hiss, works fine on my machine too.

orta commented 7 years ago

I bet it's the pod update in CI, vs pod install which we probably did

orta commented 7 years ago

OK, cool 👍

orta commented 7 years ago

@alloy this is now shipped as 4.0.2

alloy commented 7 years ago

Ahhhhhhhhhh, yeah makes total sense. Thanks 🙌