search

orta / Snapshots

An Xcode Plugin to show the state of FBSnapshot Tests.
BSD 2-Clause "Simplified" License
362 stars 29 forks source link

Xcode 7.3 Compatibility #36

Closed ashfurrow closed 8 years ago

ashfurrow commented 8 years ago

As noted in my Eigen PR, Xcode 7.3 doesn't print test results to the debug console like it used to (they're sent to a log file). Snapshots plugin will need to either read that file or (and I think Orta talked to me about this) listen for notifications from Xcode about passed/failed tests.

I'll try to take a stab at this, likely with https://github.com/ashfurrow/second_curtain/issues/40 for good measure.

orta commented 8 years ago

Probably best to setup a NSFileCoordinator for where-ever the logs come in to, I've wanted to make Snapshots standalone - and this it what it needed to do that. With that there's no need to build into Xcode.

ashfurrow commented 8 years ago

:+1: Cool, thanks for the guidance!

ashfurrow commented 8 years ago

Quick is also looking at something similar, I'll keep an eye on it to see what happens.

ashfurrow commented 8 years ago

scan/xcpretty/quick are all having issues with this. I'm not sure what the solution will be, I've looked through the generated log and plist test summaries and neither has the data as we need it. I'm not really qualified to go digging for which NSNotifications to listen to, so I'm going to have to put this aside for now.

ashfurrow commented 8 years ago

Loooooks like it might've just been a bug in Nimble: https://github.com/Quick/Nimble/pull/271 I'll keep on top of it.

raphaelcruzeiro commented 8 years ago

Any news on this? I kinda have a broken CI flow because of this issue (if there's anyway I can help, just let me know).

ashfurrow commented 8 years ago

Yes, the problem has been fixed on Nimble, but the solution is causing new problems. Since the fix is in master, we're using it and it has solved this problem for now.

Actually I think we can close this issue now, since it's not a problem with this specific project. Thoughts?

orta commented 8 years ago

Aye - I think #37 also covers this from the perspective of doing it in snapshots itself.