orta / cocoapods-keys

A key value store for storing per-developer environment and application keys
MIT License
1.55k stars 92 forks source link

osx_keychain has 10 warnings #174

Open ykws opened 7 years ago

ykws commented 7 years ago

I think resolve if merged https://github.com/seattlerb/osx_keychain/pull/2 But not yet, any idea?

bundle exec rspec spec/*_spec.rb
/Users/travis/build/orta/cocoapods-keys/vendor/bundle/ruby/2.0.0/gems/osx_keychain-1.0.1/lib/osx_keychain.rb:45:20: warning: implicit conversion loses integer precision: 'unsigned long' to 'UInt32' (aka 'unsigned int') [-Wshorten-64-to-32]
                   strlen(service), service,
                   ^~~~~~~~~~~~~~~
/Users/travis/build/orta/cocoapods-keys/vendor/bundle/ruby/2.0.0/gems/osx_keychain-1.0.1/lib/osx_keychain.rb:46:31: warning: implicit conversion loses integer precision: 'unsigned long' to 'UInt32' (aka 'unsigned int') [-Wshorten-64-to-32]
                   username ? strlen(username) : 0, username,
                              ^~~~~~~~~~~~~~~~
/Users/travis/build/orta/cocoapods-keys/vendor/bundle/ruby/2.0.0/gems/osx_keychain-1.0.1/lib/osx_keychain.rb:51:22: warning: implicit conversion loses integer precision: 'unsigned long' to 'UInt32' (aka 'unsigned int') [-Wshorten-64-to-32]
                     strlen(service), service,
                     ^~~~~~~~~~~~~~~
/Users/travis/build/orta/cocoapods-keys/vendor/bundle/ruby/2.0.0/gems/osx_keychain-1.0.1/lib/osx_keychain.rb:53:33: warning: implicit conversion loses integer precision: 'unsigned long' to 'UInt32' (aka 'unsigned int') [-Wshorten-64-to-32]
                     username ? strlen(username) : 0, username,
                                ^~~~~~~~~~~~~~~~
/Users/travis/build/orta/cocoapods-keys/vendor/bundle/ruby/2.0.0/gems/osx_keychain-1.0.1/lib/osx_keychain.rb:90:20: warning: implicit conversion loses integer precision: 'unsigned long' to 'UInt32' (aka 'unsigned int') [-Wshorten-64-to-32]
                   strlen(service), service,
                   ^~~~~~~~~~~~~~~
/Users/travis/build/orta/cocoapods-keys/vendor/bundle/ruby/2.0.0/gems/osx_keychain-1.0.1/lib/osx_keychain.rb:91:43: warning: implicit conversion loses integer precision: 'unsigned long' to 'UInt32' (aka 'unsigned int') [-Wshorten-64-to-32]
                   username == NULL ? 0 : strlen(username), username,
                                          ^~~~~~~~~~~~~~~~
/Users/travis/build/orta/cocoapods-keys/vendor/bundle/ruby/2.0.0/gems/osx_keychain-1.0.1/lib/osx_keychain.rb:97:24: warning: implicit conversion loses integer precision: 'unsigned long' to 'UInt32' (aka 'unsigned int') [-Wshorten-64-to-32]
                       strlen(password), password);
                       ^~~~~~~~~~~~~~~~
/Users/travis/build/orta/cocoapods-keys/vendor/bundle/ruby/2.0.0/gems/osx_keychain-1.0.1/lib/osx_keychain.rb:102:24: warning: implicit conversion loses integer precision: 'unsigned long' to 'UInt32' (aka 'unsigned int') [-Wshorten-64-to-32]
                       strlen(service), service,
                       ^~~~~~~~~~~~~~~
/Users/travis/build/orta/cocoapods-keys/vendor/bundle/ruby/2.0.0/gems/osx_keychain-1.0.1/lib/osx_keychain.rb:103:47: warning: implicit conversion loses integer precision: 'unsigned long' to 'UInt32' (aka 'unsigned int') [-Wshorten-64-to-32]
                       username == NULL ? 0 : strlen(username), username,
                                              ^~~~~~~~~~~~~~~~
/Users/travis/build/orta/cocoapods-keys/vendor/bundle/ruby/2.0.0/gems/osx_keychain-1.0.1/lib/osx_keychain.rb:104:24: warning: implicit conversion loses integer precision: 'unsigned long' to 'UInt32' (aka 'unsigned int') [-Wshorten-64-to-32]
                       strlen(password), password,
                       ^~~~~~~~~~~~~~~~
10 warnings generated.
patoroco commented 7 years ago

some news about that? I'm receive same errors on CircleCI, but if I connect by SSH to instance, and re-run bundle exec pod install, it doesn't show it.

In my local, the same: first execution shows warnings, but after that, no warnings...

🤷‍♂️

orta commented 7 years ago

This isn't really an issue with cocoapods-keys, I'd obviously rather not have those warnings but I have no power there. I'd recommend mentioning on the PR above.