search

orta / cocoapods-keys

A key value store for storing per-developer environment and application keys
MIT License
1.55k stars 92 forks source link

Commit 7b95b95 breaks our watchOS builds #180

Closed jcayzac closed 6 years ago

jcayzac commented 6 years ago

Hi Orta, Any particular reason you’re now restricting Cocoapods Keys to the iOS platform only? Thank you

the-pear commented 6 years ago

Build log:

Resolving dependencies of Podfile [!] The platform of the target Watch Extension (watchOS 4.0) is not compatible with Keys (1.0.1), which does not support watchos.

jcayzac commented 6 years ago

That commit also probably breaks tvos

jcayzac commented 6 years ago

(and macos)

orta commented 6 years ago

Sure, happy to have the other platforms added 👍

jcayzac commented 6 years ago

I was about to send a PR fixing this issue but @segiddins beat me to it. Except #181 actually doesn't fix anything and sets version numbers that have no root in reality. It will be another 5 years at least until anybody hears of WatchOS 8.3… 👎

jcayzac commented 6 years ago

I understand this plugin is "done" but it seems to me it currently means "unmaintained". That #181 was merged with no testing is bad. Have you considered transferring it to somebody else?

segiddins commented 6 years ago

It will be another 5 years at least until anybody hears of WatchOS 8.3… 👎

I forgot that watchOS didn't have the same version as iOS

orta commented 6 years ago

@jcayzac please be more respectful on these issues, it's great that you're contributing but I'd rather it not come with an attitude. You're welcome to help out and improve things you think are not working.