search

orta / cocoapods-keys

A key value store for storing per-developer environment and application keys
MIT License
1.55k stars 92 forks source link

🐛 Fixes #180 and add other missing platforms #183

Closed jcayzac closed 6 years ago

jcayzac commented 6 years ago

This fixes #180 by adding the missing platforms with proper minimal requirements.

Cocoapods-Keys does not use any API introduced after iOS 2.0, but requires ARC (introduced in 5.0). It does not, as far as I'm aware, require iOS 8.0. So this should also fix broken builds for apps targeting iOS 5, 6 and 7.

WatchOS 8.3 does not exist. The current version is 4.3, although this plugin is compatible with 2.0.

TvOS 8.3 also never existed. The original version was 9.0.

For OS X/macOS, there is no dependency on Yosemite (10.10). ARC was introduced in Lion (10.7).

Note: This PR does not address #182, as sanitizing the tests will require more work.

jcayzac commented 6 years ago

@orta @segiddins since 7b95b95da6c77a0daee11aa7f471d6f2dc44fa87 doesn't mention any rationale for the change introduced in 2.0.2, may I ask the reason? It seems to me that the right fix would be to revert that commit and remove that platforms field from the spec since it's basically compatible with every version of every platform supported by cocoapods that satisfies the requires_arc flag…

orta commented 6 years ago

I just picked a random, non 4.3 version, these versions seem good for me 👍