search

orta / cocoapods-keys

A key value store for storing per-developer environment and application keys
MIT License
1.55k stars 92 forks source link

Fix for duplicate keyrings in Jenkins #184

Closed SlaunchaMan closed 6 years ago

SlaunchaMan commented 6 years ago

I noticed some timeouts in Jenkins with the following format:

[15:37:12]: $ bundle exec pod install
[15:43:17]: ▸ About to create a duplicate keyring file for project REDACTED
[15:43:17]: ▸ Entries in your Apple Keychain will be shared between both projects.
[15:43:17]: ▸ Press enter to continue, or `ctrl + c` to cancel

The script is waiting for input, but since we’re on CI that isn't practical. I found this message in the project in keyring_liberator.rb and noticed that the list of environment variables it uses to determine if it's running in CI is different than in preinstaller.rb, so I copied the latter's list into the former.

I'm not super great with Ruby, so I didn't attempt to make both files pull this method from the same source file, but that would be the obvious improvement here.

orta commented 6 years ago

Yes, this is a great call

SlaunchaMan commented 6 years ago

Thanks for the release! I had a workaround of TRAVIS=0 /path/to/build/script but now I don't even need to use it!

orta commented 6 years ago

No worries, yeah, shipped as 2.0.4

~/dev/projects/cocoapods/cocoapods-keys master ⇡
❯ bundle exec rake release
cocoapods-keys 2.0.4 built to pkg/cocoapods-keys-2.0.4.gem.
Tagged v2.0.4.
Pushed git commits and tags.
Pushed cocoapods-keys 2.0.4 to rubygems.org