search

orta / cocoapods-keys

A key value store for storing per-developer environment and application keys
MIT License
1.55k stars 93 forks source link

Fix Keys.m generation when there are empty-string keys #204

Closed rogerluan closed 4 years ago

rogerluan commented 4 years ago

Resolves #203

rogerluan commented 4 years ago

CI is failing, but it's failing in master too 😬 @ashfurrow

rogerluan commented 4 years ago

Looks good 👍 Aye, CI on master could use work. I'll try to get to that this weekend.

Have you tested this locally? You can do this by modifying your Gemfile:

- gem 'cocoapods-keys'
+ gem 'cocoapods-keys', git: 'https://github.com/rogerluan/cocoapods-keys.git'

And re-run bundle install and bundle exec pod install, and that should do it.

I did yeah, using path: while developing, and then committed this to the project I work on:

- gem 'cocoapods-keys', '2.1.0'
+ gem 'cocoapods-keys', '2.2.1', github: 'rogerluan/cocoapods-keys', branch: 'master'

It works 🚀

ashfurrow commented 4 years ago

Awesome! @orta would you like to add me as an owner to the gem in RubyGems.org and I can handle publishing?

orta commented 4 years ago

Added you. You're on!

ashfurrow commented 4 years ago

Thank you @orta :bow:

Alrighty! Thanks again @rogerluan – I've pushed that as version 2.2.1 to RubyGems. Please get in touch if you find any other issues!

rogerluan commented 4 years ago

Thanks! ❤️