search

orta / danger-plugin-yarn

Provides dependency information on dependency changes in a PR *
MIT License
33 stars 13 forks source link

Don't ever print @types as it is suppressed in GFM rendering #9

Open orta opened 7 years ago

orta commented 7 years ago

screen shot 2017-09-12 at 4 49 51 pm for screen shot 2017-09-12 at 4 50 03 pm

orta commented 7 years ago

could replace with @ - @

orta commented 7 years ago

Didn't work: https://github.com/artsy/metaphysics/pull/752#issuecomment-331226951

screen shot 2017-09-21 at 1 34 07 pm

orta commented 6 years ago

perhaps we can always present those as links embedded in code?

e.g.

<a href='link.com'><code>@types/lodash</code></a>

code>@types/lodash</code

orta commented 6 years ago

https://github.com/orta/danger-plugin-yarn/commit/bca7e923c4a581f73924e3961d9c2b475d1de1fc should improve this

glensc commented 1 year ago

@orta this is fixed with https://github.com/orta/danger-plugin-yarn/commit/bca7e923c4a581f73924e3961d9c2b475d1de1fc commit?