search

orta / vscode-twoslash-queries

VS Code extension which adds support for twoslash queries into typescript projects
https://marketplace.visualstudio.com/items?itemName=Orta.vscode-twoslash-queries
MIT License
419 stars 15 forks source link

^? must be one character to the right to work #31

Closed Loskir closed 1 year ago

Loskir commented 1 year ago
image

For some reason it doesn't work if i place ^? exactly under the type I want to inspect. It has to be one character to the right to work.

Seems like no one else has this issue, but I can reproduce it on a clean vscode profile

orta commented 1 year ago

Maybe relates to #28 - we probably should have some unit tests covering the identifiers we're trying to pick up with these regexes

tommy-mitchell commented 1 year ago

Do you have a preferred testing library @orta? I wouldn't mind adding some cases and trying to fix #28.

orta commented 1 year ago

@tommy-mitchell - I believe there's one baked into the vscode extension template, so it's already in there (it just loads up a vscode instance to run them) but generally I'm a jest man, but I have no worries about whatever makes sense!

Loskir commented 1 year ago

this also seems to be fixed by #32

@/darkv thank you for the fix!