search

ortclib / ortclib-sdk

C# / C++ ORTC Lib SDK for UWP, iOS, and Android
BSD 2-Clause "Simplified" License
100 stars 36 forks source link

Generating nuget packages is broken for M66 #17

Closed Holo-Krzysztof closed 6 years ago

Holo-Krzysztof commented 6 years ago

Using the createNuget.bat script does not result in much more than just copying the template .sln to another folder; the buildWebRTC.bat script only shows the usage because a parameter is missing (due to changes to that script I suppose).

The background is that I'd like to create my own minimal sample to play around with the library without having to fiddle with its build system whenever there are upstream changes.

Anyway, I've fixed this and it seems to build and pack just fine. Should I submit a pull request for this?

jamescadd commented 6 years ago

Please do submit a PR, we'll review and accept. cc @robin-raymond @vmancic

Holo-Krzysztof commented 6 years ago

Here it is: https://github.com/ortclib/ortclib-scripts/pull/1

jamescadd commented 6 years ago

Appreciate the submission!