Fix Valuables and Diagrams on Loot Sheet

[ortegamarcel]

It seems that the Actor -> Item sheet no longer allows you to open Valuables or Diagrams, or add them to it?

Originally reported by Davrill here.

[ortegamarcel]

@Dravill I cannot find any problem. Everything works fine for me. If you still encounter that problem, please write a step-by-step guide on how to reproduce it and post the according error message from the console. (Press F12 and go to "Console".)

[Davrill]

Thank you for checking - I'll do some checking on it, and come back to you. Currently rolling back to version 10.303 and checking my backed-up files

[Davrill]

Okie, so I rolled back to the version we're using on the Forge (0.96 of AM's system), using the stable 10.303 version of VTT, and I can see the loot actor I've made: When I click the + button it adds a new one, as expected: I've then updated the Witcher System to the Alpha4 one, remaining on 10.303 build to minimise the issues, and when I open the loot chest Actor, I see the following: I can't see any of the previous items that I'd installed. If I export the Data of the Actor file - the file shows the items as being present, just not being rendered in the game. I then tried generating a new item for each of the tabs - with the result below: As you can see, it creates new files for the armours and components, but nothing for the Valuables or Diagrams - BUT is generating a 'Created item ID' in the Console. So it's creating them, but just not showing them.

When I then roll back to 0.96, the items all appear visible once more, along with the newly 'created item ID' on all the tabs, including the Valuables and Diagrams.

[Davrill]

Sorry for so many images. I also tried one more thing in the 0.96 build - making a new container actor item and dropping an item from the Valuable Compendium into it with the Console up - a number of error messages were shown? Not sure if they are relevant either:

[ortegamarcel]

Oh, I see. You meant the loot actor... yes, I can reproduce/see the problem. I will fix it. (I am using Foundry v11.305)

It's good that you post so many images, makes it easier to understand.

[Davrill]

No worries, thank you for coming back to me, and I'm glad they are useful :)

[ortegamarcel]

I fixed it, and created a Pull Request. You can find screenshots and more details there: https://github.com/ortegamarcel/TheWitcherTRPG/pull/14

I will merge it, after some more testing and it will be available with the next release v0.97-alpha.6.

[Melkkart]

Hi, after seeing this bug, I started to look at the actor sheets and the glyph, rune, etc that are dragged to a player sheet do not appear, they are there, because the weight increases, but they are not visible.