ortegamarcel / TheWitcherTRPG

FoundryVTT The witcher trpg system
GNU General Public License v3.0
2 stars 1 forks source link

My feature/show item image from inventory #8

Closed ortegamarcel closed 1 year ago

ortegamarcel commented 1 year ago

settings checkbox mouse-hover zoom-in

Problem

Some of my players have quest items in their inventory with an relevant image. Unfortunately, there is no option for them to make it bigger.

Changes

Small other changes

Melkkart commented 1 year ago

Wonderful , one question, @ortegamarcel this version of the Zoomable objects, which by the way, I love, you do not have the improvements you did before, no? I don't know if I'm doing it right, but in this version I will see the zoomable option, but for example action.js has the armature error and I don't see your improvement, the one that organizes the objects. Could you create a version that has all the improvements you have made? I don't know if it's possible, but thanks!

ortegamarcel commented 1 year ago

Wonderful , one question, @ortegamarcel this version of the Zoomable objects, which by the way, I love, you do not have the improvements you did before, no?

@Melkkart Thanks, but what improvements do you mean? The improved inventory? This is just the PR for my personal develop branch/repo. It does include all my previous changes, I just didn't change the screenshots.

I don't know if I'm doing it right, but in this version I will see the zoomable option, but for example action.js has the armature error and I don't see your improvement, the one that organizes the objects.

What action.js error do you mean? And what does it have to do with this feature?

Could you create a version that has all the improvements you have made? I don't know if it's possible, but thanks!

Sure, it is possible. But this already includes everything. Or do you mean on the other PR?

Melkkart commented 1 year ago

ok ok, nothing, don't mind me, it was my mistake, everything is fine, I've been testing and changing so much, I did something wrong. :) again thanks for everything and forgive me, I still have to learn a lot.

ortegamarcel commented 1 year ago

@Melkkart Don't worry. This happens to me often too.