search

orthanc-server / orthanc-builder

Repo used to build osimis/orthanc docker images, windows installers and OSX packages
GNU Affero General Public License v3.0
26 stars 12 forks source link

Allow passing only --user to /probes/test-aliveness.py #16

Closed denisw closed 9 months ago

denisw commented 9 months ago

So far, if you pass --user to the script, you need to pass --pwd as well. With this change, if only --user is passed, then the matching password is fetched from "RegisteredUsers" in the configuration file. That way, it is not necessary to put a secret value into a healthcheck configured in docker-compose.yml or AWS ECS, for example, while still allowing the choice of which user to use for the probe request.

amazy commented 9 months ago

@denisw thanks for that PR ! This makes a lot of sense !