search

orthecreedence / cl-async

Asynchronous IO library for Common Lisp.
MIT License
273 stars 40 forks source link

try to load latest ssl/crypto libraries on OpenBSD #160

Closed zmyrgel closed 5 years ago

zmyrgel commented 5 years ago

OpenBSD fails to load provided libcrypto/ssl libraries when loading cl-async-ssl system. The current version numbers are woefully outdated, ( 20.1 vs. 45.1 in currently used).

Easy fix would be to update the version numbers to match currently used numbers but the library will break as soons as libressl bumps versions. And how long list of version numbers should be kept in cl-async-ssl?

I think best option would be to make the code look for "libssl.so" and "libcrypto.so" libraries. This makes the OpenBSD linker to load the matching library with biggest major.minor version. This is often the right thing to do. I doubt theres enough OpenBSD Common Lisp hackers to keep hardcoded version numbers in sync.

orthecreedence commented 5 years ago

I have never used OpenBSD so can't really confirm whether this is a good idea or not, but in general linking against the versioned libraries directly seems brittle. If someone opens another PR to add specific versions, then we can cross that bridge later. Hopefully this doesn't cause issues. Thanks for the PR.