search

orthecreedence / cl-async

Asynchronous IO library for Common Lisp.
MIT License
275 stars 40 forks source link

improved spawn #166

Closed Plisp closed 5 years ago

Plisp commented 5 years ago

The call to write-pending-socket-data in spawn triggers a streamish-broken-pipe error (when attempting to write to stdout and stderr streams) which breaks tests.

Data provided through the :data argument to the stdin container is flushed at https://github.com/orthecreedence/cl-async/blob/master/src/socket.lisp#L276 meaning that the call can be removed altogether.

I have also removed what seems to be a spurious defclass in pipe.lisp

orthecreedence commented 5 years ago

I haven't dusted this project off in quite a while, so it's hard for me to verify these changes. I'll go ahead and merge though because I don't want to be an absentee project owner that never accepts changes. Thank you for the contribution =].

Plisp commented 5 years ago

You're welcome. Thanks for the great library :+1:.