search

orthecreedence / cl-async

Asynchronous IO library for Common Lisp.
MIT License
275 stars 40 forks source link

Fix for issue #188 #190

Closed hdasch closed 2 years ago

hdasch commented 2 years ago

There are five changesets here. The first four fix existing test failures to avoid needing to handwave test failures with the fifth patch -- the actual fix.

The main event (f0cc925), formalizes the patch suggested in issue #188. This provides backward compatibility with OpenSSL 1.0.1 where the patch in the bug report does not. Arguably, providing compatibility with old and probably broken OpenSSL versions is not doing anyone any favors. But this seems a more complete solution.

This has been tested with (cl-async-test::run-tests :ssl t) on Linux with the following OpenSSL and SBCL versions:

distribution OpenSSL version SBCL version
debian-08 1.0.1t 1.2.4.debian
debian-09 1.1.0l 1.3.14.debian
debian-11 1.1.1k 2.1.1.debian
orthecreedence commented 2 years ago

Thank you for this! I reviewed the changes and they all look good. I've been out of the lisp game for a while so I'm going to merge without running tests and all that...thank you for running them and verifying this is working, and thanks for keeping this project up to date :).