Closed rpgoldman closed 1 year ago
Related to the dependency issue, I just noticed that the cl-async
system definition has both a :serial t
and explicit dependency specifications through :depends-on
. I believe that the :serial t
should be removed. I wonder if this is related to these messages I see when loading:
WARNING:
Computing just-done stamp in plan NIL for action (ASDF/LISP-ACTION:PREPARE-OP
"cl-async-util"), but dependency (ASDF/LISP-ACTION:LOAD-OP
"cl-async-base") wasn't done yet!
WARNING:
Computing just-done stamp in plan NIL for action (ASDF/LISP-ACTION:PREPARE-OP
"cl-async-util"
"src/util/helpers"), but dependency (ASDF/LISP-ACTION:LOAD-OP
"cl-async-util"
"src/util/package") wasn't done yet!
WARNING:
Computing just-done stamp in plan NIL for action (ASDF/LISP-ACTION:PREPARE-OP
"cl-async-util"
"src/util/foreign"), but dependency (ASDF/LISP-ACTION:LOAD-OP
"cl-async-util"
"src/util/helpers") wasn't done yet!
WARNING:
Computing just-done stamp in plan NIL for action (ASDF/LISP-ACTION:PREPARE-OP
"cl-async-util"
"src/util/error"), but dependency (ASDF/LISP-ACTION:LOAD-OP
"cl-async-util"
"src/util/foreign") wasn't done yet!
WARNING:
Computing just-done stamp in plan NIL for action (ASDF/LISP-ACTION:PREPARE-OP
"cl-async"), but dependency (ASDF/LISP-ACTION:LOAD-OP
"cl-async-base") wasn't done yet!
WARNING:
Computing just-done stamp in plan NIL for action (ASDF/LISP-ACTION:PREPARE-OP
"cl-async"), but dependency (ASDF/FIND-SYSTEM:DEFINE-OP
"cl-async") wasn't done yet!
WARNING: redefining CL-ASYNC::ERRNO-EVENT in DEFGENERIC
When I load CL-ASYNC, I get these 2 warnings:
TL;DR -- would you welcome a PR to fix these? Happy to fix them, if so.
errno-event
This is caused by a missing ASDF system dependency.
dns.lisp has the following:
and the corresponding
defgeneric
appears in streamish.lisp. But dns.lisp does not:depends-on
streamish.streamish
functionThe defgeneric for this again appears in streamish.lisp, but it's downstream of the definition of an accessor method named
streamish
. The fix here is to move thedefgeneric
up, but that requires also detaching the enclosed:method
and putting it below thedefclass
forstreamish
.