orthecreedence / cl-async

Asynchronous IO library for Common Lisp.
MIT License
272 stars 40 forks source link

Test failures on MacOS #198

Open rpgoldman opened 1 year ago

rpgoldman commented 1 year ago

I'm seeing some test failures:

TCP-CONNECT-FAIL

TCP-CONNECT-FAIL in CL-ASYNC-TEST-CORE [Make sure a tcp connection fails]:
      Unexpected Error: #<CL-ASYNC:SOCKET-TIMEOUT {700B798CC3}>
#<SOCKET-TIMEOUT #<TCP-SOCKET {700B798913}>: -60: connection timed out {700B798CC3}>.

This may be related to an error I am seeing in cl-mqtt, which uses cl-async.

DNS-Lookup-IPV6

DNS-LOOKUP-IPV6 in CL-ASYNC-TEST-CORE [Test IPV6 family (can fail in *nix)]:

IPV6

 evaluated to

"::ffff:142.250.191.142"

 which does not satisfy

IPV6-ADDRESS-P

This may not be a big deal, because there is a note that it might not work on Unix-alikes.

INTERVAL

I'm not sure about this one; it doesn't fail reliably. But under some circumstances, it fails as follows:

 INTERVAL in CL-ASYNC-TEST-CORE [Test intervals]:

3

 evaluated to

3

 which is not

EQ

 to

2

Unfortunately, I don't understand what this test is trying to establish. It looks like it increments c every .1s and then checks after .32s, expecting the increment to happen only twice, but for me sometimes it happens 3 times.

Minor correction: comparison of integers should be done with eql or =, not eq. Integers of equal values are not required to be eq:

numbers with the same value need not be eq, [from the ANSI spec]