orthecreedence / wookie

Asynchronous HTTP server in common lisp
http://wookie.lyonbros.com/
MIT License
189 stars 19 forks source link

Cookie data not all available #50

Closed nightshade427 closed 10 years ago

nightshade427 commented 10 years ago

If I do a POST to wookie the browser says its sending liek 10 cookie keys with reqest, but if I look inside wookie request and even the raw http-request inside the wookie request object, it only has one cookie key?

Browser, inspector of sent data to server.

WT_FPC=id=ab22c358-9d42-4570-b634-4e3e5696b810:lv=1400452836601:ss=1400452821890; _dyaud_sess=**; rsi_segs=D08734_72771|D08734_71611|D08734_70008|D08734_71701|D08734_70033|D08734_70086|D08734_71682|D08734_72787|D08734_71095|D08734_70068|D08734_70094|D08734_71743|D08734_70043|D08734_70663|D08734_72016|D08734_72014|D08734_72018|D08734_72019|D08734_70671|D08734_71730|D08734_70623|D08734_71737|D08734_71738|D08734_70629|D08734_72414|D08734_70665|D08734_70667|D08734_70672|D08734_70031|D08734_70691|D08734_70042|D08734_70051|D08734_70056|D08734_70071|D08734_70078; __utma=87316239.908575572.1389635468.1400170125.1400609725.14; __utmc=87316239; __utmz=87316239.1389635468.1.1.utmcsr=(direct)|utmccn=(direct)|utmcmd=(none); s_vnum_n2_us=3%7C17%2C0%7C14%2C1%7C4%2C5%7C10%2C4%7C9; s_cc=true; s_orientation=%5B%5BB%5D%5D; s_sq=%5B%5BB%5D%5D; s_orientationHeight=420; s_fid=7139E2CD36E04B6E-180F81E0C0CE1E3B; _translatify_session=BAh7B0kiD3Nlc3Npb25faWQGOgZFRkkiJTIzYjNmODc2Yzk2MDUyODM0MTU1YTBmNDAzNWNhOWU2BjsAVEkiEF9jc3JmX3Rva2VuBjsARkkiMXhQQ2FWUnM3U1pMTzJJb0d6ZDlKb3ViVFR3Mkk1N1poUEY0RTNKRVRHckk9BjsARg%3D%3D--d225d872c1a5792b1232ea7956a624d464ed05af

available in wookie

(:COOKIE . "WT_FPC=id=ab22c358-9d42-4570-b634-4e3e5696b810:lv=1400452836601")
orthecreedence commented 10 years ago

This is actually an http-parse bug (https://github.com/orthecreedence/http-parse/commit/bb5729c4f88c111c9c48392cd44dc6bc916ff542).

It wasn't splitting headers properly, so it was just throwing out the cookie data. I tried it after my fix with your exact cookie string and it appears all 13 cookies are coming through, but please confirm.

nightshade427 commented 10 years ago

Perfect!! Thanks again :)