search

ortiza5 / modding-vivaldi

A not-even-WIP-anymore collection of guides about modifying the Vivaldi browser
The Unlicense
7 stars 1 forks source link

Sharing Mods (4) #10

Open code3z opened 3 years ago

code3z commented 3 years ago

What comment should be used at the top of mod files? What tags should be used in forum posts? Should we ask people to include screenshots or anything else?

What tools are good for making an animated GIF?

Zalext commented 3 years ago

About the Comments, I had suggested what I've seen on the Forum Topic itself. For Tags, Luetage said on the Topic: Type:: CSS/Js - Element:: Panel/TabBar/BookmarksBar/... BackUp:: Themes/BKs/SearchEngines...

And combine them with that or a better kind of order

Screenshots and Gifs are very useful. For Gifs, on Win LiceCap works fine.

code3z commented 3 years ago

The other thing is, put mod settings above the meta header.

code3z commented 3 years ago

I think mods should also have the “mod” tag to distinguish them from questions posted to the mod forum.

Zalext commented 3 years ago

Mod Settings?

Yes, To add Mod as Tag was said also.

code3z commented 3 years ago

While ideally mod settings would be put in vivaldi://settings, they are often put in code. That code could be at the very top, then the informational header, then the main code.

ghost commented 3 years ago

That code could be at the very top, then the informational header

I’d swap these two.

code3z commented 3 years ago

I will do this one as well.

code3z commented 3 years ago

That code could be at the very top, then the informational header

I’d swap these two.

@tiosgz Why? Because it makes more sense? Because that's the way we've always done it? Because it's hard to convince people to change too many things at once?

Not trying to be picky, just asking.

ghost commented 3 years ago

Because those comments are always at the very beginning, mostly due to parsing, but here also because it provides an easy way for people to split mods dumped into one file.

code3z commented 3 years ago

Should this be closed now that a corresponding pull request is opened?

code3z commented 3 years ago

Whoops, wrong issue

ghost commented 3 years ago

Should this be closed now that a corresponding pull request is opened

Nope. But you should add something like

Fixes #10

to the PR’s OP so that it is automatically closed once the PR is merged. (Thinking of it, you don’t have to. But it’s a good practice.)

https://docsify.js.org/#/

I could set this up once we have 6 or so pages

Wrong issue? #11