search

ortiza5 / modding-vivaldi

A not-even-WIP-anymore collection of guides about modifying the Vivaldi browser
The Unlicense
7 stars 1 forks source link

Sharing and using the forum #15

Open code3z opened 3 years ago

code3z commented 3 years ago

Here we can discuss sharing and using the forum. I put this into a folder called "forum" (should I change the name or purpose?).

I know people have strong opinions about this so I'd like each section I write to be approved by at least one other person.

Read here: https://github.com/code3z/modding-vivaldi/tree/sharing/forum

Resolves #10

code3z commented 3 years ago

I like this format that allows for only taking parts of large CSS mods: https://github.com/GabeVilela/Vivaldi-GX

Would this go in “Community” or Advaced CSS?

ghost commented 3 years ago

I like this format that allows for only taking parts of large CSS mods: https://github.com/GabeVilela/Vivaldi-GX

Would this go in “Community” or Advaced CSS?

That would go into managing mods, so neither.

code3z commented 3 years ago

Ok. It could be mentioned in sharing but the instructions are in managing.

code3z commented 3 years ago

How should I add images? Should I wait until I set up GH pages?

ghost commented 3 years ago

How should I add images? Should I wait until I set up GH pages?

As it is usually done in MD (use relative path for them, I think GH will sort it out correctly)

code3z commented 3 years ago

Ok, I guess the relative path would have a ../

code3z commented 3 years ago

What else would you like to see before merging?

ghost commented 3 years ago

What else would you like to see before merging?

I need to re-read it, & you need to fix conflicts with CONTRIBUTING.md

code3z commented 3 years ago

Images and other resources like them are in an assets/ directory in the root of the corresponding “project,” structured according to their use.

So modding-vivaldi/community/assets or modding-vivaldi/assets?

ghost commented 3 years ago

modding-vivaldi/assets (for now the whole repo is one ‘project’)

ghost commented 3 years ago

I was wondering what you had done with the text – are you writing a song? That note sometime somewhere about ‘logical places to add newlines in code’ doesn’t apply to plain text. And why the indentation?

code3z commented 3 years ago

the text – are you writing a song? That note sometime somewhere about ‘logical places to add newlines in code’ doesn’t apply to plain text. And why the indentation?

This is what CONTRIBUTING said! Keep the lines to 80 char, right?

ghost commented 3 years ago

Yeah, but you often go way farther, & sometimes the newline is very soon. And the leading spaces must definitely be a mistake.

code3z commented 3 years ago

Ok. Would you be okay with exactly 75-100 char?

code3z commented 3 years ago

Anything else I need to do?

code3z commented 3 years ago

@tiosgz or @ortiza5 Could you re-review this soon?

ghost commented 3 years ago

Yeah, sorry for the delay. I wanted to review all pending PRs today, but it seems it’ll take at least part of tomorrow as well.

code3z commented 3 years ago

No worries, sorry for being impatient, do it whenever you have time.

code3z commented 3 years ago

Other than the updated tagging information after the forum admins fix tagging, is this ready to merge?

ghost commented 3 years ago

I don’t know, will have to review it again. I guess I’ll have some tiny fixes at least. Sorry, cannot review today, but hopefully tomorrow I’ll be able to.

ghost commented 3 years ago

So that’s most of it (f66d57cbde7d375a77e5eaf08fcd33067fedaa72 to 5018df00303f1b0e0fe220046bf0c4c8a763fc2b). If you want to revert something – no problem if you give a good reason against mine.

Currently I see two problems (once they are solved I may see more 😉)

Hmm… and it might go into basics/, since it is a ‘basic modding skill’ in some way.

code3z commented 3 years ago

Looks nice, thank you. It sounds like tagging will be re-enabled, assuming that isn't too far into the future I will wait until that happens to merge the final draft. I will look into the organization soon.