search

ortiza5 / modding-vivaldi

A not-even-WIP-anymore collection of guides about modifying the Vivaldi browser
The Unlicense
7 stars 1 forks source link

inspect to structural #36

Closed luetage closed 3 years ago

luetage commented 3 years ago

reintegrate inspect changes

ghost commented 3 years ago

Reposting this, otherwise I guess it’s mostly OK. Well, what about the file name? You can inspect a lot of things, but ‘devtools’ usually refers only to one thing.

$ grep -nE '^.{81,}$' inspect.md
18:- Open **`vivaldi://settings/`** (in a **tab**), or **`vivaldi://experiments/`**,
21:- Enable “Show Introduction” for private windows in `vivaldi://settings/privacy/`.
46:1. Open DevTools and click the element picker button (mouse pointer) on top left.
68:   the “Sources” tab and in the sidebar expand `vivaldi-data` and then `css-mods`.

(took out 145, since that’s okay)

luetage commented 3 years ago

I have no idea what 145 is, nor why it’s ok. Anyway, I’ll do the file name change since I don’t really care what the file is called.

luetage commented 3 years ago

pushed

ghost commented 3 years ago

I have no idea what 145 is, nor why it’s ok.

Line 145 – it’s ok because it is a link definition. But please fix the other matched lines, they are longer than 80 chars.

And you forgot to update the link in the README.

luetage commented 3 years ago

The whole point of 80 columns is keeping it nice and tight. I broke the 80 column rule on purpose in places it went over the bounds with non letter characters. I think this makes much sense and keeps the code very readable.

ghost commented 3 years ago

Okay. I’ll give @code3z & @ortiza5 time til tomorrow in case they have any suggestions, & then merge it.

luetage commented 3 years ago

And about the overlong link at the end, as far as I know it won’t work anymore when you break it up. That’s why I put all of this at the bottom in the first place.

code3z commented 3 years ago

Great! @tiosgz maybe you could add the short description in the readme, like

Installation—I’ve got some code, what to do with it? Inspecting the Interface—Something should go here