Previous implementation produced produced incorrect/invalid values when target and observer were very close. The updated equation should now produce the correct value for any target/observer distance. Also updated documentation to explicitly state how this value is calculated (i.e. using arcsin(body.r_eq / body.target_distance)).
Pull request checklist
[x] Add a clear description of the change
[x] Add any new tests needed
[x] Run spell check on new text visible to user (documentation, GUI etc.)
[x] Check any changes to requirements.txt are reflected in setup.py and conda-forge feedstock
[x] Check code passes CI checks (run run_ci.sh or check GitHub Actions)
Previous implementation produced produced incorrect/invalid values when target and observer were very close. The updated equation should now produce the correct value for any target/observer distance. Also updated documentation to explicitly state how this value is calculated (i.e. using
arcsin(body.r_eq / body.target_distance)
).Pull request checklist
requirements.txt
are reflected insetup.py
and conda-forge feedstockrun_ci.sh
or check GitHub Actions)See CONTRIBUTING.md for more details.