ortk95 / planetmapper

PlanetMapper: An open source Python package for visualising, navigating and mapping Solar System observations
https://planetmapper.readthedocs.io
MIT License
10 stars 1 forks source link

Correct calculation of `target_diameter_arcsec` for targets located very close to the observer #343

Closed ortk95 closed 6 months ago

ortk95 commented 6 months ago

Previous implementation produced produced incorrect/invalid values when target and observer were very close. The updated equation should now produce the correct value for any target/observer distance. Also updated documentation to explicitly state how this value is calculated (i.e. using arcsin(body.r_eq / body.target_distance)).

Pull request checklist

See CONTRIBUTING.md for more details.

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 8265549026

Details


Totals Coverage Status
Change from base Build 8265480670: 0.0%
Covered Lines: 2880
Relevant Lines: 2892

💛 - Coveralls