Update PlanetMapper for compatibility with NumPy 2.0 - Githubissues

ortk95 / planetmapper

PlanetMapper: An open source Python package for visualising, navigating and mapping Solar System observations

https://planetmapper.readthedocs.io

MIT License

10 stars 1 forks source link

Update PlanetMapper for compatibility with NumPy 2.0 #344

Closed ortk95 closed 4 months ago

ortk95 commented 6 months ago

Minor updates to work with the new major version of NumPy (2.0).

This pull request also changes the tests so that any warnings are raised as errors. This causes e.g. a DeprecationWarning will cause a test to fail, ensuring it is fixed before releasing.

Closes #301

Pull request checklist

[x] Add a clear description of the change
[x] Add any new tests needed
[x] Run spell check on new text visible to user (documentation, GUI etc.)
[x] Check any changes to requirements.txt are reflected in setup.py and conda-forge feedstock
[x] Check code passes CI checks (run run_ci.sh or check GitHub Actions)

See CONTRIBUTING.md for more details.

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 8983678304

Details

13 of 13 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 99.574%

Totals
Change from base Build 8265866928:	0.001%
Covered Lines:	2888
Relevant Lines:	2900

💛 - Coveralls

ortk95 commented 4 months ago

We're just waiting for astropy 6.1, which adds numpy 2.0 compatibility https://github.com/ortk95/planetmapper/issues/301#issuecomment-2037126065

ortk95 commented 4 months ago

Checks all pass locally with numpy 2.0.0rc1