ortk95 / planetmapper

PlanetMapper: An open source Python package for visualising, navigating and mapping Solar System observations
https://planetmapper.readthedocs.io
MIT License
10 stars 1 forks source link

Make `add_satellites_to_bodies_of_interest` more permissive of SPICE errors #354

Closed ortk95 closed 4 months ago

ortk95 commented 4 months ago

Body.add_satellites_to_bodies_of_interest will now silently handle any SpiceSPKINSUFFDATA errors for any other_target_id that doesn't have an associated name in the SPICE kernels. This ensures that ID codes for non-existent satellites don't raise unneeded errors.

This is basically equivalent to the previous (pre v1.10.0) behaviour, as before #352 any body without a defined name would raise a NotFoundError rather than a SpiceSPKINSUFFDATA error.

Pull request checklist

See CONTRIBUTING.md for more details.

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9004700490

Details


Totals Coverage Status
Change from base Build 8984094433: 0.08%
Covered Lines: 2913
Relevant Lines: 2925

💛 - Coveralls