Closed ortk95 closed 3 months ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Totals | |
---|---|
Change from base Build 9480466937: | 0.0% |
Covered Lines: | 2955 |
Relevant Lines: | 2968 |
For some input values (e.g. for identical input points),
SpiceBase.angular_dist
returned NaN. This was due to the accumulation of small floating point errors causing the code to evaluate e.g.np.arccos(1.0000000000000002) -> NaN
rather than the correctnp.arccos(1.0) -> 0.0
. This has been fixed by clipping the value innp.arccos
to ensure it always lies between -1 and 1.Closes #357
Pull request checklist
requirements.txt
are reflected insetup.py
and conda-forge feedstockrun_ci.sh
or check GitHub Actions)See CONTRIBUTING.md for more details.