ortk95 / planetmapper

PlanetMapper: An open source Python package for visualising, navigating and mapping Solar System observations
https://planetmapper.readthedocs.io
MIT License
10 stars 1 forks source link

Check custom proj projection strings have the correct `+axis=...` parameter before mapping #398

Closed ortk95 closed 5 days ago

ortk95 commented 5 days ago

If a custom proj projection string is used when mapping, check the string's +axis parameter is consistent with the positive longitude direction of the body. I.e. positive west bodies should have +axis=wnu and positive east bodies should have +axis=enu. If the wrong +axis parameter is used, then the output map is likely to be flipped and therefore incorrect, so PlanetMapper now raises a ProjStringError exception if the positive longitude direction and +axis parameters are inconsistent.

Also updated relevant documentation to suggest using create_proj_string, which automatically generates the correct +axis parameter for the body.

Closes #397

Pull request checklist

See CONTRIBUTING.md for more details.

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 10847283847

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Totals Coverage Status
Change from base Build 10470286746: 0.001%
Covered Lines: 3163
Relevant Lines: 3175

đź’› - Coveralls