ortuman / SwiftForms

A small and lightweight library written in Swift that allows you to easily create forms.
MIT License
1.33k stars 209 forks source link

example dismiss button closure not called #135

Closed appsird closed 8 years ago

appsird commented 8 years ago

Your SwiftFormsApplication has a Dismiss button with a row.configuration.button.didSelectClosure being set.

Though, when I set a breakpoint on the single line in this enclosure, the breakpoint does not get hit when the Dismiss button is pressed.

I'm running with the SwiftForms-Swift3 branch in iOS 10.

Any ideas on why this might be is appreciated.

appsird commented 8 years ago

Correction, the breakpoint is hit in your example.

I attempted to override a gesture to allow clicking outside the form fields to the put away the soft keyboard if necessary using the following in the view controller:

    let tap: UITapGestureRecognizer = UITapGestureRecognizer(target: self, action: #selector(dismissKeyboard))
    view.addGestureRecognizer(tap)

and also used this extension:

extension UIViewController { func hideKeyboardWhenTappedAround() { let tap: UITapGestureRecognizer = UITapGestureRecognizer(target: self, action: #selector(UIViewController.dismissKeyboard)) view.addGestureRecognizer(tap) }

func dismissKeyboard() {
    view.endEditing(true)
}

}

Though, apparently this disrupts normal operation. Is there a means to allow tucking the soft keyboard when desired?

appsird commented 8 years ago

given I can scroll the view, dismiss is not a high priority. I will close this issue.