oruebel / ndx-icephys-meta

NWB extensions for origanizing intracellular electrophysiology metadata
Other
6 stars 0 forks source link

Minor fixes to run readme code using latest HDMF #80

Closed rly closed 3 years ago

rly commented 3 years ago

Update AlignedDynamicTable.__fields__ to not redefine the field description inherited from DynamicTable.

AlignedDynamicTable.__contains__(...) allows arguments of type str and tuple, but must allow the test condition None in table, for example, in https://github.com/hdmf-dev/hdmf/blob/dev/src/hdmf/common/io/table.py#L30

This can be solved by changing docval for __contains__ to allow NoneType by making 'val' optional (there is no straightforward way to allow NoneType without making it optional) or by removing the docval entirely. I decided to remove the docval because it did not seem necessary to mess with the in operator.

Tests are still failing but at least the example in README.md now runs without error.