fix(angular): add request overloads based on observe property

orval-labs / orval

orval is able to generate client with appropriate type-signatures (TypeScript) from any valid OpenAPI v3 or Swagger v2 specification, either in yaml or json formats. 🍺

https://orval.dev

MIT License

3.21k stars 337 forks source link

fix(angular): add request overloads based on observe property #1633

Closed QuietNatu closed 2 months ago

QuietNatu commented 2 months ago

Status

READY

Description

Fixes #1631

Updated generateImplementation to add function overloads when isRequestOptions is true.
This ensures that when supplying observe to a request, it's return type will match what is returned by the HttpClient.

Todos

[ ] Tests
[ ] Documentation
[ ] Changelog Entry (unreleased)

melloware commented 2 months ago

Hmm looks like a build failure.

QuietNatu commented 2 months ago

It seems to me that the yarn.lock has not been updated with yesterday's 7.1.1 release.

melloware commented 2 months ago

Agreed @anymaniax ?

melloware commented 2 months ago

OK made progress now some test failures!