ory / cli

Create bulk action scripts, automate your tasks, manage your projects, and seamlessly interact with the Ory Network using the Ory command line interface (CLI).
https://www.ory.sh/cli?utm_source=github&utm_medium=banner&utm_campaign=cli
Apache License 2.0
42 stars 22 forks source link

tunnel asks to open application from browser on login/registration flow requiring redirects #236

Open Benehiko opened 2 years ago

Benehiko commented 2 years ago

Preflight checklist

Describe the bug

On any flow that requires a browser redirect the browser will ask to open an application instead of doing the redirect.

For example:

A login flow image

A registration flow image

On logout we have the same problem image

Flows not affected

I have also tested this on SPA applications which have no redirects on login, registration etc. However on logout we redirect to Kratos which opens the dialog.

Reproducing the bug

  1. spin tunnel up on localhost:4000
  2. start node express app on localhost:3000
  3. do a login/registration flow by visiting localhost:3000
  4. the browser will ask to open a new application

Relevant log output

No response

Relevant configuration

No response

Version

v0.1.43

On which operating system are you observing this issue?

Linux

In which environment are you deploying?

Ory Cloud

Additional Context

No response

aeneasr commented 2 years ago

I can't reproduce this. Is the problem maybe the changes you have made to the node app?

Benehiko commented 2 years ago

I can't reproduce this. Is the problem maybe the changes you have made to the node app?

this also happens with the elements/react-spa example on logout. so i don't think it's related to the implementation.

aeneasr commented 2 years ago

I'm trying the examples from the docs and can not reproduce the problem! E2E tests for proxy are also passing

Benehiko commented 2 years ago

I will try with the docs examples as well quick.

The problem is with tunnel afaik - haven't tried proxy - and the e2e tests in docs do not test against tunnel.

aeneasr commented 2 years ago

I tested it with the tunnel and the React app. The e2e tests in Ory CLI test both proxy and tunnel :)

Benehiko commented 2 years ago

Tested this on another machine and it seems to work normally... not really sure what's different in my environment that could cause this :thinking:

I will investigate it a bit later and report back here.