added AuthConfigs to BuildOptions and pass that to BuildImage

ory / dockertest

Write better integration tests! Dockertest helps you boot up ephermal docker images for your Go tests with minimal work.

https://www.ory.sh/?utm_source=github&utm_medium=banner&utm_campaign=dockertest

Apache License 2.0

4.15k stars 243 forks source link

added AuthConfigs to BuildOptions and pass that to BuildImage #488

Closed DGollings closed 2 weeks ago

DGollings commented 11 months ago

Please consider this a 'naive PR' - we ran into an issue where although it was possible to pass along authentication to the run commands but not the build.

This fixes it, but I'm wondering why this wasn't already possible or whether I'm doing something else wrong

And i'm wondering why dockertest did not use already present and logged in ~/.docker/config.json

Either way, thanks for dockertest, it has already been used tens of thousands of times by us :)

CLAassistant commented 11 months ago

All committers have signed the CLA.

aeneasr commented 2 weeks ago

Awesome, thank you for your contribution!