ory / elements

Ory Elements is a component library that makes building login, registration and account pages for Ory a breeze. Check out the components library on Chromatic https://www.chromatic.com/library?appId=63b58e306cfd32348fa48d50
https://ory.sh
Apache License 2.0
85 stars 44 forks source link

Toggle switch to show the user's password when on the UserSettingsCard #116

Closed kevinbtesar closed 1 year ago

kevinbtesar commented 1 year ago

Preflight checklist

Describe your problem

My feature request is not related to a problem or issue. This request concerns the SettingsFlow. The concern is that once the user has submitted the password reset code, we take them to the UserSetting card within the auth flow. At this point, they can enter their new password. However, there is no way to confirm they have entered their desired value. If an incorrect value is entered, they are forced to go through the password reset process for a second time.

Describe your ideal solution

Our ideal solution is a toggle switch that shows the entered value in the password field as clear text. I'll paste in a mockup our Project Manager and Lead Designer created in Zeplin that illustrates our request.

image

Workarounds or alternatives

An alternative would be a password confirmation box. I.e., a second password input field that confirms the characters match the value in the first password input field.

Version

v0.0.1-beta.7

Additional Context

I have no additional context at this time.

Thank you

Benehiko commented 1 year ago

I have been looking into this, please take a look at the draft PR. Suggestions are welcome! :)

kevinbtesar commented 1 year ago

@Benehiko That is awesome! Thank you! I can't try it out right now due to other pressing tasks, but PM will check it out and give me the go-ahead when it's apt for our project. However, I looked over the changes, and they seemed solid. Thanks again!

Benehiko commented 1 year ago

Hi @kevinbtesar

I actually found another problem with this implementation when using native form posts (since there are now technically two fields with the same name in the form). I'm busy fixing that quick in a different PR.

kevinbtesar commented 1 year ago

@Benehiko That sounds like a plan. No rush. However, I will watch this thread to inform my bosses about your progress.

Do you think the issue/feature request should be reopened until fully addressed?

Benehiko commented 1 year ago

Sorry about all of the delays, the latest version should now be working :)

kevinbtesar commented 1 year ago

@Benehiko No worries at all! While I can't test it out yet, I looked at your changes, and it seems to be super easy to implement. Many thanks from me, my team, and everyone at Pulsar!!