ory / elements

Ory Elements is a component library that makes building login, registration and account pages for Ory a breeze. Check out the components library on Chromatic https://www.chromatic.com/library?appId=63b58e306cfd32348fa48d50
https://ory.sh
Apache License 2.0
85 stars 44 forks source link

fix: fallbacks for non-react client #127

Closed Benehiko closed 1 year ago

Benehiko commented 1 year ago

Related Issue or Design Document

useId does not fallback now when the React import is null. This means express cannot use the @ory/elements-markup package.

TypeError: Cannot read properties of null (reading 'useId')
    at ln (/home/benehiko/Github/elements/packages/markup/dist/index.umd.js:29:1199)
    at Nav$1 (/home/benehiko/Github/elements/packages/markup/dist/index.umd.js:69:17981)
    at Nav (/home/benehiko/Github/elements/packages/markup/dist/index.umd.js:173:19625)
    at navigationMenu (/home/benehiko/Github/kratos-selfservice-ui-node/src/pkg/ui.ts:83:13)
    at /home/benehiko/Github/kratos-selfservice-ui-node/src/routes/welcome.ts:33:26
    at step (/home/benehiko/Github/kratos-selfservice-ui-node/src/routes/welcome.ts:33:23)
    at Object.next (/home/benehiko/Github/kratos-selfservice-ui-node/src/routes/welcome.ts:14:53)
    at fulfilled (/home/benehiko/Github/kratos-selfservice-ui-node/src/routes/welcome.ts:5:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
[nodemon] app crashed - waiting for file changes before starting...

Checklist

Further comments