feat: strict eslint - Githubissues

ory / elements

Ory Elements is a component library that makes building login, registration and account pages for Ory a breeze. Check out the components library on Chromatic https://www.chromatic.com/library?appId=63b58e306cfd32348fa48d50

https://ory.sh

Apache License 2.0

84 stars 41 forks source link

feat: strict eslint #148

Closed Benehiko closed 9 months ago

Benehiko commented 9 months ago

Related Issue or Design Document

This PR adds stricter type checking to the code base. This allows us to catch bugs early in the library as well as in playwright tests.

Tests were also added to some of the components to ensure they behave as expected, such as the error messages. Translation tests now also checks that template strings exist within the translation based on the english version.

Checklist

[ ] I have read the contributing guidelines and signed the CLA.
[ ] I have referenced an issue containing the design document if my change introduces a new feature.
[ ] I have read the security policy.
[ ] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security vulnerability, I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added the necessary documentation within the code base (if appropriate).

Further comments