feat: hide label on hidden input type - Githubissues

ory / elements

Ory Elements is a component library that makes building login, registration and account pages for Ory a breeze. Check out the components library on Chromatic https://www.chromatic.com/library?appId=63b58e306cfd32348fa48d50

https://ory.sh

Apache License 2.0

84 stars 41 forks source link

feat: hide label on hidden input type #149

Closed Benehiko closed 9 months ago

Benehiko commented 9 months ago

Related Issue or Design Document

Hide the label if the input field is of a hidden type.

In Ory Kratos one-time code flow we have access to the input fields after the initial submit (step 2 of 3). Kratos will send back the nodes as hidden fields which will still have their labels attached.

Related to this PR https://github.com/ory/kratos/pull/3516

Also fixes the resend button. The auth-code-section component did not render the hidden input field to specify the method when submitting the resend button. This is now fixed and the test assertions fixed.

Checklist

[ ] I have read the contributing guidelines and signed the CLA.
[ ] I have referenced an issue containing the design document if my change introduces a new feature.
[ ] I have read the security policy.
[ ] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security vulnerability, I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added the necessary documentation within the code base (if appropriate).

Further comments