fix: disable button on submit

[hperl]

Related Issue or Design Document

Checklist

• [ ] I have read the contributing guidelines and signed the CLA.
• [ ] I have referenced an issue containing the design document if my change introduces a new feature.
• [ ] I have read the security policy.
• [ ] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security vulnerability, I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
• [ ] I have added tests that prove my fix is effective or that my feature works.
• [ ] I have added the necessary documentation within the code base (if appropriate).

Further comments

[jonas-jonas]

This doesn't actually work. The reason is, that the click event fires before the submit event of the enclosing form, and disabling the button in the event stops event propagation. There are a few solutions, but IMO we should just get this right in AX2 before spending any more time on this. The underlying issue is fixed either way, and this was purely cosmetic.

[alnr]

Wouldn't the fix just be to change click to submit?

[jonas-jonas]

Wouldn't the fix just be to change click to submit?

Submit fires on the form, not the button itself.

[alnr]

https://chat.openai.com/share/b85618ff-b1c3-4c28-b36f-44d35556216c

[jonas-jonas]

yea, as I linked there are solutions, just don't want to spend time on getting this right, right now. PRs welcome ;)