ory / examples

A curated collection of examples and solutions created and maintained by the Ory Community.
https://www.ory.sh/community/
Apache License 2.0
135 stars 67 forks source link

Ory kratos feedback: hot reload errors freeze the software #48

Closed alexandrebrg closed 10 months ago

alexandrebrg commented 1 year ago

Author

This feedback is from someone who tried kratos/hydra for the first time to do a POC. He used a community example as a base code.

Problem

He encountered some developer experience problems while trying it:

He is running kratos with hot-reload (--dev) and he is tweaking configuration files. Whenever he puts an error into an url property in the configuration files kratos returns HTTP 403 and logs show github.com/ory/kratos/x.CSRFErrorReason. This is intended, however whenever he puts back a working url in this property, he still gets HTTP 403 and that CSRF error. In order to have a working kratos instance again, he needs to restart the software.

Here are a few properties he encountered this problem on:

How to reproduce

  1. Git clone community example
  2. Follow README to run kratos/hydra and ensure it works
  3. Update kratos configuration by editing selfservice.methods.oidc.config.providers.id.mapper_url to a wrong URL
  4. Let the hot reload do the job
  5. Revert changes
  6. See HTTP 403 errors
github-actions[bot] commented 11 months ago

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️