search

ory / examples

A curated collection of examples and solutions created and maintained by the Ory Community.
https://www.ory.sh/community/
Apache License 2.0
140 stars 67 forks source link

feat: add desktop support to flutter example #91

Open Corbie-42 opened 8 months ago

Corbie-42 commented 8 months ago

Add build targets Linux, macOS and Windows.

This was done by executing:

flutter create --platforms=windows,macos,linux --project-name ory_network_flutter flutter-ory-network

and adjusting the clientId of the GoogleSignIn in main.dart, so that it is (currently) disabled on desktop.

CLAassistant commented 8 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Corbie-42 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Corbie-42 commented 8 months ago

Okay, I see that you

  1. expect the conventional commits to have an unconventional list of commit titles as body
  2. expect the copyright year to be updated on the first PR on master
  3. require the CLA to be singed. I don't want my email address to be linked to this account, so I won't sign the CLA. Feel free to reproduce the steps or take over this PR.
vinckr commented 8 months ago

Hello @Corbie-42 Thanks for your contribution! I will see to bring the repo in order soon. Should be a week or two until I find time to take a closer look at this.

The commits check just failed because it expects a conventional commit PR title, fixed it.

As for the CLA there is unfortunately no way around signing it as we might want to use your contribution in our documentation etc.